Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [PATCH] more small directional cleanups
Home

[Freeciv-Dev] Re: [PATCH] more small directional cleanups

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>
Cc: Freeciv-dev mailing list <freeciv-dev@xxxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [PATCH] more small directional cleanups
From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
Date: Tue, 21 Aug 2001 16:32:46 -0700 (PDT)

On Tue, 21 Aug 2001, Ross W. Wetmore wrote:
> 
> Note that normalized_map_pos() returns TRUE when it doesn't do anything, 
> and the return status means the position is normalized, or in normal form.

There is no function called normalized_map_pos().  It is normalize_map_pos(),
notice that normalize is a VERB.  The function take a position and normalizes
it, returning true if it was sucessful and false it was unable to noralize it.

> Normalized is a perfectly good word to use in an adjective context, and
> does not have to have the connotation that something was not in a particular
> form, just that it is *now* in that form.

No, you're wrong.  It is a passive participial adjective and should be used
to describe a noun that is receiving the effects of an action.

> and call this function is_normalized_map_pos() with a comment that anyone

How about is_norm_map_pos()?  That way it can be short for either normal if
you speak English, or normalized if you speak MustMakeSimpleWordsComplexish.



[Prev in Thread] Current Thread [Next in Thread]