[Freeciv-Dev] Re: [PATCH] more small directional cleanups

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Aug 21, 2001 at 09:22:36AM -0400, Ross W. Wetmore wrote:
> At 09:41 AM 01/08/21 +0200, Raimar Falke wrote:
> >On Mon, Aug 20, 2001 at 04:46:05PM -0700, Trent Piepho wrote:
> >> On Mon, 20 Aug 2001, Raimar Falke wrote:
> >> > It looks like the discussion about this topic just stopped without
> >> > coming to a conclusion what to do. And a big part of the thread was
> >> > just about definitions. So I made as as explicit as possible. So what
> >> > about "is_normalized_pos" and "ensure_normalized_pos"? Where
> >> > normalized is from my A,B,C definition.
> >> 
> >> Well, way back before the latest definition thread started, someone, I
> think
> >> it was Jason or I, purposed is_normal_tile to compliment the function
> >> is_real_tile.  The definition was the same as you used for your A,B,C sets.
> >
> >IMHO this all is about positions and not tiles. IMHO it should be
> >called "normalized" instead of "normal" see the threads for reasons.
> >
> >     Raimar
> >-- 
> > email: rf13@xxxxxxxxxxxxxxxxx
> > "SIGDANGER - The System is likely to crash soon"
> 
> Actually, calling it "tile" serves to remind one that these are gaming
> coordinates which are only valid when talking about real tiles, and not
> abstract coordinate positions as in a GUI window, for instance :-).

The use of map positions is overhelming compared to other
positions. Also the gui positions are transfered quickly into map
positions and are usually called canvas_[xy].

> But map_pos serves a similar purpose, though not just "pos" alone.

Fine with me.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The very concept of PNP is a lovely dream that simply does not translate to
  reality. The confusion of manually doing stuff is nothing compared to the
  confusion of computers trying to do stuff and getting it wrong, which they
  gleefully do with great enthusiasm." 
    -- Jinx Tigr in the SDM