[Freeciv-Dev] Re: [PATCH] more small directional cleanups

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 11:05 PM 01/08/21 +0200, Raimar Falke wrote:
>On Tue, Aug 21, 2001 at 12:33:55PM -0700, Trent Piepho wrote:
>> If you think normal isn't clear enough, because it can mean lots of things,
>> then pick another proper adjective.  Like "canonical".  Or "proper".
But not
>> a past particple like "normalized"!
>
>What do you think about "is_standard_position", "is_true_position" and
>"is_normal_format_position"?
>
>       Raimar
>
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
> "Many of my assistants were fans of Tolkien, who wrote 'Lord of the Rings'
>  and a number of other children's stories for adults.  The first character
>  alphabet that was programmed for my plotter was Elvish rather than Latin."
>    -- from SAIs "life as a computer for a quarter of a century"

Note that normalized_map_pos() returns TRUE when it doesn't do anything, 
and the return status means the position is normalized, or in normal form.

Normalized is a perfectly good word to use in an adjective context, and
does not have to have the connotation that something was not in a particular
form, just that it is *now* in that form.

So ...

If, as and until one changes the entire code base to reflect the subtleties
of regional English dialect interpretations, I suggest we go with the code
and call this function is_normalized_map_pos() with a comment that anyone
that uses it needs to be prepared for a long fight about the suitability of 
the name and whether s/he should be the one to propagate the global change,
and that it has no valid known use in anything but asserts anyway :-).

Cheers,
RossW
=====