[Freeciv-Dev] Re: [PATCH] more small directional cleanups

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Aug 20, 2001 at 06:05:53PM -0700, Trent Piepho wrote:
> On Mon, 20 Aug 2001, Ross W. Wetmore wrote:
> > If you are checking to see if the coordinates are normalized so you 
> > don't have to call normalize_map_pos() this is false economy, as that
> > function doesn't do anything to the coordinates if they are normalized.
> 
> I think the point of is_normal_tile() was for assert calls, to help trap cases
> where non-normal positions were used where they shouldn't be.

Yes. And for exactly this reason (assertion is the main use of
is_normal_tile) I would like a method ensure_*. Less writing and more
grouping (it is easy to search for other usages of is_normal_tile).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "- Amiga Y2K fixes (a bit late, wouldn't you say?)"
    -- Linus Torvalds about linux 2.4.0 at 4 Jan 2001