Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [PATCH] more small directional cleanups 		Home

[Freeciv-Dev] Re: [PATCH] more small directional cleanups

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jason Dorje Short <jshort@xxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] more small directional cleanups
From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
Date: Wed, 22 Aug 2001 01:39:34 -0700 (PDT) 
On Wed, 22 Aug 2001, Jason Dorje Short wrote:
> 
> > > +  int dirs[8] = {0, 1, 2, 3, 4, 5, 6, 7}; /* list of all 8 directions */
> > 
> > You introduce new magic numbers?
> 
> They're not magic; all they assume about the directional system is that
> the directions go 0-7 (which is also implied by DIR_DX/DIR_DY arrays). 

My code didn't assume the the directional system was 0-7.  They could be
numbered 1-8 and it would still work.
[Prev in Thread] Current Thread [Next in Thread]