[Freeciv-Dev] Re: [PATCH] more small directional cleanups

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Aug 22, 2001 at 07:06:16PM -0400, Ross W. Wetmore wrote:
> At 05:30 PM 01/08/22 +0200, Raimar Falke wrote:
> >On Wed, Aug 22, 2001 at 10:44:35AM -0400, Ross W. Wetmore wrote:
> [...]
> >> Corecleanup_06a is a more comprehensive cleanup that apart from the things
> >> it inherited from the first dir_patch, tries to do what is needed for the
> >> long term with as few intermediate sidetracks as possible. But this sort of
> >> comprehensive patch appears not as easily accepted by the maintainers as
> your
> >> quickie stepwise versions. I haven't had any real feedback or direct
> >> acknowledgment of these changes yet, though if the clock started running
> >> officially last Sunday, it is not unreasonable for someone to still be
> >> trying to digest the full meal. It is also overlayed on your dir_patch and
> >> I haven't seen this go in either so there is a potential queuing delay.
> >
> >I'm sorry Ross. I looked at some of the patches and I also tought I
> >sent comments and so I waited for a new version from you. Looking at
> >the archive I have only commented on the autogame.
> 
> No reason to be sorry ... while I was needling the maintainers a little 
> for which I apologize, and which your earlier posting of patch status has
> more than made up for, I hope I indicated that it was a little early for
> more than a quick eval of something like corecleanup_06a. There is nothing
> tricky there once you understand the pattern of the 3 or 4 types of change
> but there are a lot of places to check if you are being conscientious.
> 
> And when you are done and it is in Freeciv will be a lot more robust :-).
> 
> If it helps, you should be able take individual diff blocks for each file
> or at least a begin/end pair, and apply them separately. Most of the 
> changes are local and obvious. So if you aren't sure about some spots, 
> just edit them out to a separate file and resolve them later.
> 
> If you send me any such edits I will both tell you if not applying this 
> breaks something less obvious, and what the particular sections are 
> actually doing. You need the top 3 lines of the diff along with any
> complete @@ blocks to make a new mini-diff.
> 
> But at a first cut I think you can assume that most of corecleanup_06a
> is one-off local bugfixes. It also has had several hours of autogaming
> and client autogame testing, i.e. the intermediate fixes were applied
> built and separately tested as this patch in addition to having been
> around for quite awhile in my final source tree, which is almost
> continuosuly under autogame testing (the machine has nothing better to
> do when I'm not around :-).

Yes there are simple replacing operations. But as I'm conscientious to
best for me would 5-10 medium sized patches.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  This message has been ROT-13 encrypted twice for extra security.