[Freeciv-Dev] Re: [PATCH] more small directional cleanups

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Aug 22, 2001 at 01:39:34AM -0700, Trent Piepho wrote:
> On Wed, 22 Aug 2001, Jason Dorje Short wrote:
> > 
> > > > +  int dirs[8] = {0, 1, 2, 3, 4, 5, 6, 7}; /* list of all 8 directions 
> > > > */
> > > 
> > > You introduce new magic numbers?
> > 
> > They're not magic; all they assume about the directional system is that
> > the directions go 0-7 (which is also implied by DIR_DX/DIR_DY arrays). 
> 
> My code didn't assume the the directional system was 0-7.  They could be
> numbered 1-8 and it would still work.

With MAPSTEP (which capsulates DIR_DX/DIR_DY) I would like to change
the directions in the long term just to uncover other errors.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 Make a software that is foolproof, and only fools will want to use it.