[Freeciv-Dev] Re: [PATCH] more small directional cleanups

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 07:43 PM 01/08/21 -0400, Jason Dorje Short wrote:
>Erik Sigra wrote:
>
>> The confusion here is that something can be normal but not normalized,
if it
>> was represented in conventional form from the beginning and has not
undergone
>> the process of normalization.
>
>You're speaking from an English symantics point of view.
>
>From a mathematical point of view the past is irrelevant.  Just by
>passing the is_normalized_map_pos check we could consider the
>coordinates to have been "normalized".
>
>jason

Moreover, who says that the NULL transformation is not a valid normalization
even from a symantics point of view, and thus anything that is now
normalized can be said to have undergone a normalization process.

Jason's is_normal(ized)_map_pos at least has the sanity (from a
programmer's) point of view of not introducing new names and terminology
for something that is already in the code.

My only concern is that we not forget what this is to be used for and make
its sibling functions as obviously siblings as possible. Which is why I
prefer normalize and is_normalized as part of the symmetry. This way no one
can
reasonably argue that normalize_map_pos doesn't produce an is_normalized
TRUE result. Normal is different enough to introduce unnecessary ambiguity
and 
possibility for argument, however slight this possibility might be :-) :-).

Cheers,
RossW