Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2001:
[Freeciv-Dev] Re: Winsock patch
Home

[Freeciv-Dev] Re: Winsock patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jeff Mallatt <jjm@xxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Winsock patch
From: Andreas Kemnade <akemnade@xxxxxxxxxxx>
Date: Wed, 14 Feb 2001 15:25:56 +0100 (CET)

Jeff Mallatt writes:
 > At 2001/02/13 11:50 , Andreas Kemnade wrote:
 > >Jeff Mallatt writes:
 > > > At 2001/02/13 10:16 , Andreas Kemnade wrote:
 > > > >I think we should use the old SOCKET_ZERO_ISNT_STDIN code and move it
 > > > >to support.c instead of using that fileno() stuff because this code
 > > > >should work because it is in CVS. (Don't change a running system)
 > > > 
 > > > My patch did attempt to return (mostly) to using the "old
 > > > SOCKET_ZERO_ISNT_STDIN" code, moved to support.c.  I guess you are
 > > > suggesting that it go all the way and do the character-by-character input
 > > > processing, right?
 > > > 
 > >Yes
 > 
 > This includes both codes, conditionalized by a "#if 0".
 > 
 > It looks like both Mac and BeOS ports use SOCKET_ZERO_ISNT_STDIN.  If both
 > these folks could test both codes and come to some consensus as to which,
 > if either, works best, we could remove the other...
I have tested to compile a win32 server with your patch. It works!
I think that the patch is ready for committing. 

Greetings
Andreas Kemnade



[Prev in Thread] Current Thread [Next in Thread]