Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2001:
[Freeciv-Dev] Re: Cleanup in map.c
Home

[Freeciv-Dev] Re: Cleanup in map.c

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Thue <thue@xxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Cleanup in map.c
From: Gaute B Strokkenes <gs234@xxxxxxxxx>
Date: 11 Jan 2001 16:51:17 +0000

On Wed, 10 Jan 2001, thue@xxxxxxx wrote:

> If you look in the buttom of map.c you will see severel functions
> like
> 
> void map_set_continent(int x, int y, int val)
> {
>     (map.tiles + map_adjust_x(x) + y * map.xsize)->continent=val;
> }
> 
> Which is a bad way of inlining map_get_tile(), the kind of
> optimizing I did NOT like. 

Yup.

> Gaute talked about a patch to inline some functions like
> map_get_tile(). When you make that patch, could you also fix those
> functions?

I will.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
UH-OH!!  I think KEN is OVER-DUE on his R.V. PAYMENTS and HE'S
 having a NERVOUS BREAKDOWN too!!  Ha ha.



[Prev in Thread] Current Thread [Next in Thread]