[Freeciv-Dev] Re: Cleanup in map.c

[Thue <thue@xxxxxxx>]

On Wednesday 10 January 2001 02:28, Thue wrote:
> This makes sure most of the functions in map.c don't try to count
> non-existing tiles. If the rest of the code is modified the same way it
> will also make it more or less trivial to implement things like torus maps,
> flat maps and maps with real isometric grids.
>
> There seemed to be a bug in is_terrain_clean(); fixed.
>
> -Thue

A slightly updated patch that actually works.

If you look in the buttom of map.c you will see severel functions like 

void map_set_continent(int x, int y, int val)
{
    (map.tiles + map_adjust_x(x) + y * map.xsize)->continent=val;
}

Which is a bad way of inlining map_get_tile(), the kind of optimizing I did 
NOT like. Gaute talked about a patch to inline some functions like 
map_get_tile(). When you make that patch, could you also fix those functions?

-Thue

update_map_funcs.diff
Description: Text Data