[Freeciv-Dev] Re: Patch: Limited player information to client

[Thue <thue@xxxxxxx>]

> > > -You should send information about the revolution state to players with
> > > embassy
> >
> >  You mean revolution counter? Client does not currently have any use for
> > (opponents) revolution counter. I don't think opponent should know how
> > long it will take before my revolution ends (in fact, neither should
> > I...) You can tell that opponent is going through revolution when his
> > government is anarchy (and this is sent at infolevel INFO_MEETING).
>
> In government.ruleset there is the line
> when_anarchy="Anarchy"
> so concievably, with a custom ruleset, this could be republic or another
> normal government. So you cannot count on the government to decide if you
> are having a revolution. The revolution field can be used for this.
> Players with an embassy should at least know whether another player is
> having a revolution. I think that for any player you should hide the number
> of turns to exiting revolution, fx by
> packet->revolution = pplayer->revolution ? 1 : 0;

Ok, admitted. If when_anarchy was set to republic you could compare it with 
the ruleset. But it is still possible that the starting government was the 
same as the anarchy one, so the problem and solution remains.

-Thue