Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2000:
[Freeciv-Dev] Re: client goto & patrol
Home

[Freeciv-Dev] Re: client goto & patrol

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: thue@xxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: client goto & patrol
From: Gaute B Strokkenes <gs234@xxxxxxxxx>
Date: 15 Oct 2000 03:10:21 +0100

Thue <thue@xxxxxxx> writes:

> On Sat, 14 Oct 2000 19:19:52 Thue wrote:
> > Ok, it should really be ready now.
> > 
> > -saving and loading had a bug
> > -patrol now doesn't pop up diplomat dialogs when a diplomat passes through
> an
> > allied city (added arg to do_unit_goto())
> > -the sending of variable length routes now works.
> > 
> > http://hjem.get2net.dk/thue_janus_kristensen/client_goto_diff.gz
> http://hjem.get2net.dk/thue_janus_kristensen/client_goto.diff.gz of course...

Looks great to me.  A couple of comments:

* I think `goto_array_pointer' -> `goto_array_index' might be a good
  idea...  (Reverse Hungarianism, ho hum.)

* Spelling: `peice' -> `piece' and 'lenght' -> `length'

* In goto_array_insert() you might as well just use fc_realloc().

-- 
Big Gaute (not to be confused with LG)
These PRESERVES should be FORCE-FED to PENTAGON OFFICIALS!!



[Prev in Thread] Current Thread [Next in Thread]