[Freeciv-Dev] Re: somebody fix struct *player! (was: FoW remove player bug)

[Reinier Post <rp@xxxxxxxxxx>]

> OTOH, it's not clear to me why you need to re-order the players ever
> --- if a player is removed, and that leaves a 'hole' in the player
> array indexes, does that matter?

The Freeciv code does not yet attempt to hide the game struct.
Iterations over players are always written out, like this:

  for (plrnum=0; plrnum<game.nplayers; ++plrnum) {
    struct player *pplayer = &game.player[plrnum];
    [...]
  }

Standard access operators can be written in game.h, to iterate over
game.players, and to add/remove elements.  A C++ version would have
had this abstraction from the start, but in C we can make do with macros.

-- 
Reinier