[Freeciv-Dev] Re: somebody fix struct *player! (was: FoW remove player bug)

[Thue Janus Kristensen <thue@xxxxxxx>]

Just a note: I am going to apply a patch that makes some functions that
access bitvectors in maphand.c use playerid instead of struct player
*pplayer.

This should be done as it is a waste of CPU to extract the player number
(index in the bitvectors) from player struct each time the functions are
called. (and it is called a lot)
Even if you decide to mess with the player numbers the functions
should still take the players index in the bitvector as argument :).
The patch has already been submitted to the list once, but is attached
again.

Also, I will apply the renumbering patch today or tomorrow, as of now the
CVS doesn't actually work. You can always remove the code again when/if
a patch is made to rework the player handling.

-Thue

FoW-cleanup.diff
Description: Text Data