[Freeciv-Dev] Re: somebody fix struct *player! (was: FoW remove player bug)

[Daniel Burrows <Daniel_Burrows@xxxxxxxxx>]

On Wed, May 17, 2000 at 04:42:13PM +0200, Thue Janus Kristensen <thue@xxxxxxx> 
was heard to say:
> On Wed, 17 May 2000, Mika Korhonen wrote:
> > On Wed, 17 May 2000, Thue Janus Kristensen wrote:
> > >Btw; maybe these oneilne functions like map_get_know() should be made into
> > >macros to avoid the overhead of a function call; is the saving worth it?
> > >Is there any reason not to?
> > 
> > Or what about making them inline which is effectively the same thing?
> > (Don't some compilers with sufficient flags already do that for short
> > functions, do they?)
> > 
> >     Mika    
> 
> no, inline would not work.
> -it only substitutes for occurences in the same file

  The same goes for macros. [1]

> -it is not standard C; only GNU C.

  That's a good reason to avoid it, IMO.  It may be part of a new standard
(as someone pointed out), but that doesn't mean that it'll be supported by more
than a handful of compilers.

  Daniel

  [1] "the same file" can, of course, mean "anything in the input stream,
     including things inserted by the C preprocessor"

-- 
/----------------- Daniel Burrows <Daniel_Burrows@xxxxxxxxx> -----------------\
|         This space        |       If you wish to live wisely,               |
|       intentionally       |       ignore sayings--including this one.       |
|        left blank.        |                                                 |
\------- (if (not (understand-this)) (go-to http://www.schemers.org)) --------/