[Freeciv-Dev] Re: somebody fix struct *player! (was: FoW remove player bug)

[Reinier Post <rp@xxxxxxxxxx>]

> Yes, some parts of the code it is smartest to use the player pointer. So
> use that there. It is just not smart when manipulating units, maps and
> bitvectors.

Yes, I agree.  What needs to be done is to make both of these, once
assigned to a player, stay the same for that player throughout the player's
existence.  It doesn't really matter which of the two are used.

> > No, all you need to do is to keep the references around by which players
> > are identified.  Removal will be an operation on game.players[] as it is
> > now, or maybe a boolean .exists can be added to the player struct
> > for convenience.
> 
> As far as I can see that was excactly what I suggested :)

OK, in that case I didn't understand your suggestion.

If I ever have a spare weekend (not any time soon) I'll try to
create the patch.

-- 
Reinier