[Freeciv-Dev] Re: Bug #202 : transporter content shown instead of the transport

[Thue Janus Kristensen <thue.kristensen@xxxxxxxxxx>]

On Wed, 15 Mar 2000, Jeff Mallatt wrote:
> At 2000/03/15 11:01 , you wrote:
> >On Wed, 15 Mar 2000, Jeff Mallatt wrote:
> >> Oops.  Just discovered a bug with this.  Units which attack from a
> >> transporter are not seen by the victim.  E.g., put a Marines on a
> >> Transport, and attack something along the shore with the Marines directly
> >> from the Transport.  The victim player doesn't see the Marines -- just the
> >> Transport.
> >
> >That would affect ships attacking from a square containing a transport
> too. :(
> >I'll have a look.

Ok - new patch attacked.
To make sure the attacking and defending units were shown on top
set_unit_focus_no_center was previously used, as it had the sideeffect of
putting the focus_no_center'ed unit first in the genlist, and so picked by
get_visible_unit (HACK!). I introduced 2 new pointers in control.h (is that the
estetically right place?) named punit_attacking and punit_defending that when
non-NULL point to units that should be shown on top, and handle them in
get_visible_unit.
I included and tested the code for gui-xaw beside gui-gtk.

-Thue

show_transporter_on_top-Mar-15.diff
Description: Text Data