Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2000:
[Freeciv-Dev] Re: 'cmdlevel first' patch (PR#296)
Home

[Freeciv-Dev] Re: 'cmdlevel first' patch (PR#296)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rp@xxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: 'cmdlevel first' patch (PR#296)
From: David Pfitzner <dwp@xxxxxxxxxxxxxx>
Date: Sun, 12 Mar 2000 19:03:17 +1100 (EST)

On Wed, 8 Mar 2000, Reinier Post wrote:

> Version 4.  This version is now installed on civserver.freeciv.org
> (backported to 1.10.0.).  It includes the cmdlevel of players into
> /list output.
> 
> This patch is very extremely small, and harmless as far as I'm aware;
> I would appreciate some comments from CVS maintainers.

One point I noticed is that the 'first' cmdlevel doesn't really
just apply to the 'first' connection, it applies to the connection
with connection number 0.

Eg, players A and B connect; player A gets cmdlevel 'first'.
Then player A disconnects and player C connects.  Now player C 
gets cmdlevel 'first', because connection 0 was unused so gets 
used for C.

Now this may be ok, if it is better to have _someone_ in control,
rather than no-one, but it doesn't follow the documentation for 
'cmdlevel first' in the patch.

-- David



[Prev in Thread] Current Thread [Next in Thread]