Complete.Org: Mailing Lists: Archives: freeciv-ai: April 2003:
[freeciv-ai] Re: New settler code

[freeciv-ai] Re: New settler code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Freeciv AI development <freeciv-ai@xxxxxxxxxxx>
Subject: [freeciv-ai] Re: New settler code
From: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Fri, 11 Apr 2003 20:50:20 +0100 (BST)

On Fri, 11 Apr 2003, Per I. Mathisen wrote:

> A new patch, and some (rather incoherent) notes.
>   - We cache and gain massive increase in speed (thanks to Greg).

Please give me some info on that.  In particular,
1. in aisettler.c
  } else if (cachemap[map_x][map_y].sum == -1 || !is_city_center(i, j)) {
    /* We cannot read city center from cache */
Why "!is_city_center(i, j)" ??

2. Are you sure you initialize your cache in the right place?
I think when you get to contemplate_new_city, your cache is not 
necessarily yours!

Personally, I would store player id and turn number near cachemap and do a 
check in find_best_city_placement.  Ok, you would have more checks, but 
you would ensure that the cachemap is fresh without having to unspaghetti 
the other code.

Another thing, I am not sure why you call citycache a cache, it's very 

BTW, the numbers you provided are very impressive!


[Prev in Thread] Current Thread [Next in Thread]