[freeciv-ai] Re: Slimmer Corecleaups

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 06:46 PM 02/04/18 -0700, Raahul Kumar wrote:
>These are my patches taken from Ross's Corecleanup series 13. I've removed
all 
>dependencies on other code in Ross's cleanups, and I am sending in only those
>parts of the corecleanups that affect the AI. 
>
>What I did:
>
>Remove any deps that prevent his AI changes from compiling against current
CVS
>Make the patches in smaller chunks
>
>This patch only affects advdomestic.c. It contains both cleanups and
behaviour
>changes.
>
>Ross: I will remove any parts of your corecleanups that I do not like in my
>series of patches. If you wish to control what your patches look like when
they
>get into CVS, take over from me.

If you drive you have control over the destination, that's fine with me :-)

>I will not touch any other part of Ross's corecleanups. I do not understand a
>great deal of it, so help would be appreciated.

If you want to raise any part for discussion, either formally or informally,
again go for it. I'm also willing to cut out any of the relevant pieces as
mini-patches for the purposes of such discussion since at least for the
first cut, I may stand a better chance of pulling all the bits together
if they are spread over several areas.

>These patches have had no TESTING. I haven't even been able to compile due to
>autogen.sh problems. So if someone on this list would like to run autogames I
>would be happy. Note: This patch does introduce behaviour change. It's a
mix of
>cleanup and changes that should stop the AI changing its build order so
often. 
>
>I've made no improvements on the original code. 

I suspect that on closer review there will be lots of things to change.
A number of updates are truly experimental what ifs. So wale away (or
wail away as the case may be) ...

It might help in discussions if the sorts of suggested changes came in
a reasonable order.
1)  General agreement or discussion of the direction/technique used.
2)  Enhancements, missing elements and other technical bugfixes.
3)  Cosmetic complaints when it looks like the patch is stabilizing
    towards CVS inclusion.

>Aloha,
>RK. 

BTW: Thanks for taking an interest in the patch enough to do the legwork
     on pieces you find intriguing.

>One day the King decided that he would force all his subjects to tell
>the truth.  A gallows was erected in front of the city gates.  A herald
>announced, "Whoever would enter the city must first answer the truth to
>a question which will be put to him."  Nasrudin was first in line.  The
>captain of the guard asked him, "Where are you going?  Tell the truth
>-- the alternative is death by hanging."  "I am going," said Nasrudin,
>"to be hanged on that gallows."  "I don't believe you."  "Very well, if
>I have told a lie, then hang me!" "But that would make it the truth!"
>"Exactly," said Nasrudin, "your truth."
>
>__________________________________________________
>Do You Yahoo!?
>Yahoo! Tax Center - online filing with TurboTax
>http://taxes.yahoo.com/
>Attachment Converted: "c:\program files\eudora\attach\advdomestic.zip"

Cheers,
RossW
=====