[freeciv-i18n] Re: Freeciv po files

[Christian Knoke <chrisk@xxxxxxxx>]

On Thu, Aug 22, 2002 at 05:53:28PM +0200, Christian Knoke wrote:
> 
> On Thu, Aug 22, 2002 at 02:17:55PM +0200, Davide Pagnin wrote:
> > 
> > > > #: server/unittools.c:1902
> > > > #, c-format
> > > > msgid "Game: %s lost to an attack by %s's %s%s."
> > > > msgstr "Spiel: %s beim Angriff von %ss %s%s verloren."
> > > 
> > > Yes, it is.
> > > 
> > > As far as I remember the last %s can be an 's' or empty.
> > > The German plural isn't an 's'. So it would be wrong to use it.
> > 
> > I've reviewed you assertion and something seems wrong to me...
> > 
> > This is server/unittools.c:1902 code:
> >     notify_player_ex(pplayer, punit->x, punit->y, E_UNIT_LOST,
> >                      _("Game: %s lost to an attack by %s's %s%s."),
> >                      unit_type(punit)->name, destroyer->name,
> >                      unit_name(pkiller->type), loc_str);
> > 
> > First %s is the unit type name.
> > Second %s is the name of the destroyer of your unit
> > Third %s is the unit type name of the winning unit.
> > 
> > The fourth %s, the relevant one, is somewhat misterious (loc_str) but if
> > you check in the code you'll find that:
> > 
> > 1. loc_str = get_location_str_in(pplayer, punit->x, punit->y);
> > 2. get_location_str return 5 possible strings (" at %s", " in %s", "
> > outside %s", " near %s", "") that are city proximity hints.
> > 
> > THUS, with actual German translation, those hint are no more given to
> > German player...
> 
> Dooh! I noticed this long time ago, but when I looked into de.po
> I didn't understand ...
> 
> There should be a TRANS: note in the source.

Here's a patch.

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.


-- Attached file included as plaintext by Ecartis --

--- server/unittools.c.orig     Tue Aug 20 09:48:19 2002
+++ server/unittools.c  Fri Aug 23 21:14:07 2002
@@ -1899,6 +1899,9 @@
       map_has_special(punit->x, punit->y, S_AIRBASE) ||
       unitcount == 1) {
     notify_player_ex(pplayer, punit->x, punit->y, E_UNIT_LOST,
+
+    /* TRANS: The last '%s' is replaced by a locational */ 
+    /* TRANS: attribute like " near Rome" e.g. */
                     _("Game: %s lost to an attack by %s's %s%s."),
                     unit_type(punit)->name, destroyer->name,
                     unit_name(pkiller->type), loc_str);