[freeciv-i18n] Re: Freeciv po files

[Davide Pagnin <nightmare@xxxxxxxxxx>]

        Hi all!

On Wed, 2002-08-21 at 20:04, Egbert Hinzen wrote:
> On 21 Aug 2002, Davide Pagnin wrote:
> 
> > de.po:5255: number of format specifications in 'msgid' and 'msgstr' does
> > not match
> >
> > This error is triggered by this translation:
> >
> > #: server/unittools.c:1902
> > #, c-format
> > msgid "Game: %s lost to an attack by %s's %s%s."
> > msgstr "Spiel: %s beim Angriff von %ss %s verloren."
> >
> > (notice the lack of %s%s in the translation)
> >
> > I using this instead completely wrong (in german?)
> >
> > #: server/unittools.c:1902
> > #, c-format
> > msgid "Game: %s lost to an attack by %s's %s%s."
> > msgstr "Spiel: %s beim Angriff von %ss %s%s verloren."
> 
> Yes, it is.
> 
> As far as I remember the last %s can be an 's' or empty.
> The German plural isn't an 's'. So it would be wrong to use it.

I've reviewed you assertion and something seems wrong to me...

This is server/unittools.c:1902 code:
    notify_player_ex(pplayer, punit->x, punit->y, E_UNIT_LOST,
                     _("Game: %s lost to an attack by %s's %s%s."),
                     unit_type(punit)->name, destroyer->name,
                     unit_name(pkiller->type), loc_str);

First %s is the unit type name.
Second %s is the name of the destroyer of your unit
Third %s is the unit type name of the winning unit.

The fourth %s, the relevant one, is somewhat misterious (loc_str) but if
you check in the code you'll find that:

1. loc_str = get_location_str_in(pplayer, punit->x, punit->y);
2. get_location_str return 5 possible strings (" at %s", " in %s", "
outside %s", " near %s", "") that are city proximity hints.

THUS, with actual German translation, those hint are no more given to
German player...

I think that you can reconsider your objection to the -c crusade,
because as you can see in this case, a translation error has been
found...

Again, I suggest to review all problematic strings and I think that
maintainers will certainly cooperate in correcting English strings if
they are problematic.

        Ciao, Davide