[Freeciv-Dev] Re: (PR#12833) consider_settler_action simplification (rev.)

["Brian Dunstan" <bdunstan149@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12833 >


--- Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> <URL:
> http://bugs.freeciv.org/Ticket/Display.html?id=12833
> >
> 
> Brian Dunstan wrote:
> 
> >     total_value = 
> >       ((discount_value * base_value)
> >         / (MAX(1, base_value - discount_value))) /
> 64;
> 
> Can you tell me what this line does?

I cannot say for certain.  My preference would be to
leave that line out.


> 
> I've read the comment but it seems useless.  Unless
> I totally
> misunderstand ammortize() this line seems completely
> wrong.
> 
> -jason
> 
> 
> 
> 
> 


                
__________________________________ 
Yahoo! Mail Mobile 
Take Yahoo! Mail with you! Check email on your mobile phone. 
http://mobile.yahoo.com/learn/mail