[Freeciv-Dev] Re: (PR#12833) consider_settler_action simplification (rev.)

["Brian Dunstan" <bdunstan149@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12833 >


--- Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> <URL:
> http://bugs.freeciv.org/Ticket/Display.html?id=12833
> >
> 
> Brian Dunstan wrote:
> 
> > ====================
> > I think this would suffice:
> > ===================
> > 
> > if (consider) {
> >     base_value = 
> >       MAX(0, new_tile_value - old_tile_value) +
> >       MAX(0, extra);
> > 
> >     discount_value = amortize(base_value, delay);
> >     total_value = MAX(0, discount_value);
> > 
> >   } else {
> >     total_value = 0;
> >   }
> 
> What happened to 'extra'?
> 
> It's a hack but without the extra consideration
> given to some
> improvements (roads, pollution cleanup) the AI
> doesn't give it nearly
> enough importance.
> 
> The "extra" values correspond to the XXX_WEIGHTING
> values on some sort
> of absolute scale.  That is, an 'extra' of 50 (a
> common value) is as
> good as +3 food.  So there is some logic here.
> 
> -jason

My mistake, corrected below.  My earlier patch has the
exra still in there :)   Extra is nice also to make
sure pollution is cleaned up.

> > ====================
> > I think this would suffice:
> > ===================
> > 
> > if (consider) {
> >     base_value = 
> >       MAX(0, new_tile_value - old_tile_value) +
> >       MAX(0, extra);
> > 
> >     discount_value = amortize(base_value, delay);
> >     total_value = MAX(0, discount_value);
> > 
> >   } else {
> >     total_value = 0;
> >   }





                
__________________________________ 
Do you Yahoo!? 
Plan great trips with Yahoo! Travel: Now over 17,000 guides!
http://travel.yahoo.com/p-travelguide