[Freeciv-Dev] Re: (PR#12833) consider_settler_action simplification

["Brian Dunstan" <bdunstan149@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12833 >


--- Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> <URL:
> http://bugs.freeciv.org/Ticket/Display.html?id=12833
> >
> 
> STOP.
> 
> Before we take this discussion any further, can you
> tell me why the
> "extra" value is -1 in most cases, and why this is
> added on to the
> pre-ammortized value?  It looks to me like an extra
> -64 is added on to
> almost every improvement consideration.  This
> (minimalist) patch should
> fix it.
> 
> Am I missing something?
> 
> -jason
> 

I think that patch is a good idea, but do not think it
will alter the behavior much.  diff=(new_tile_value -
old_tile_value) is also multiplied by 64 before
amortization, so that -1 addition will be overwhelmed
almost all of the time.  There's no chance that
amortize() will be fed a negative number, or that a
negative number will be returned as the discounted
value of the improvement.


> 
> > Index: server/settlers.c
>
===================================================================
> RCS file:
> /home/freeciv/CVS/freeciv/server/settlers.c,v
> retrieving revision 1.209.2.5
> diff -u -r1.209.2.5 settlers.c
> --- server/settlers.c 13 Feb 2005 19:17:23 -0000
> 1.209.2.5
> +++ server/settlers.c 19 Apr 2005 02:11:16 -0000
> @@ -772,6 +772,7 @@
>      consider = TRUE;
>    } else {
>      consider = (new_tile_value > old_tile_value);
> +    extra = 0;
>    }
>  
>    if (consider) {
> 


                
__________________________________ 
Do you Yahoo!? 
Plan great trips with Yahoo! Travel: Now over 17,000 guides!
http://travel.yahoo.com/p-travelguide