Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2005:
[Freeciv-Dev] (PR#12117) default events for message dialog need fixing
Home

[Freeciv-Dev] (PR#12117) default events for message dialog need fixing

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#12117) default events for message dialog need fixing
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 5 Feb 2005 01:57:00 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12117 >

- I removed the city-may-soon-grow message, since this is the most
common and one of the least useful ones.

- I removed the worklist-events message, since this one is really ugly
(two lines) and not very useful.

- I ADDED the tech-learned message, since this is IMO one of the most
useful ones.

- I removed all messages from going to the output window (chatline) by
default.  By doing this the chatline actually becomes useful for
chatting!  However in the long run it would be better to have a separate
output and chat windows.

-jason

? patch.diff
? win32.diff
Index: client/options.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/options.c,v
retrieving revision 1.103.2.1
diff -u -r1.103.2.1 options.c
--- client/options.c    9 Oct 2004 16:00:37 -0000       1.103.2.1
+++ client/options.c    5 Feb 2005 09:54:32 -0000
@@ -330,18 +330,19 @@
   int out_only[] = { E_IMP_BUY, E_IMP_SOLD, E_UNIT_BUY,
                     E_UNIT_LOST_ATT, E_UNIT_WIN_ATT, E_GAME_START,
                     E_NATION_SELECTED, E_CITY_BUILD, E_NEXT_YEAR,
-                    E_TECH_LEARNED, E_CITY_PRODUCTION_CHANGED};
+                    E_CITY_PRODUCTION_CHANGED,
+                    E_CITY_MAY_SOON_GROW, E_WORKLIST};
   int all[] = { E_MESSAGE_WALL };
   int i;
 
   for(i=0; i<E_LAST; i++) {
-    messages_where[i] = MW_OUTPUT | MW_MESSAGES;
+    messages_where[i] = MW_MESSAGES;
   }
   for (i = 0; i < ARRAY_SIZE(out_only); i++) {
-    messages_where[out_only[i]] = MW_OUTPUT;
+    messages_where[out_only[i]] = 0;
   }
   for (i = 0; i < ARRAY_SIZE(all); i++) {
-    messages_where[all[i]] = MW_OUTPUT | MW_MESSAGES | MW_POPUP;
+    messages_where[all[i]] = MW_MESSAGES | MW_POPUP;
   }
   
   for (i = 0; i < ARRAY_SIZE(event_to_index); i++) {

[Prev in Thread] Current Thread [Next in Thread]