[Freeciv-Dev] Re: (PR#10858) Oracle doesn't work on Temples outside its own city

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10858 >

On Sat, 6 Nov 2004, Jason Short wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10858 >
>
> Jason Short wrote:
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=10858 >
> >
> > Looks to me like the oracle is just wrong in the ruleset.  Does this
> > patch give the correct behavior?
> >
> > The helptext for oracle says "Doubles the effect of Temples, in all your
> > cities".
>
> However this is impossible with the current effects code!

Yeah. It used to be possible when it had operators (*2). But now it isn't.
Since we should get multiple requirements in eventually (its a nice
feature to have, e.g. an effect that depends on two buildings) I didn't
consider it important.

> Temples give either 1 or 2 Make_Content based on a tech req.  So to
> double we need to also give either 1 or 2.  However this is impossible
> because we'd have to have 2 reqs plus the source (source=>oracle,
> req=>mysticism, req=>temple).  This isn't a big problem because it's
> hard (but not impossible) to get oracle without mysticism since it's a
> building tech_req.

Yep, that was the reasoning I had. Only possibility of that happening is
if you conquer a city with an Oracle when you don't have Mysticism.

> For the default ruleset the fix is just to change the helptext.  For the
> civ1 and civ2 rulesets this becomes a known bug.

> Can you confirm that this patch fixes the problem?

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa