Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2004:
[Freeciv-Dev] Re: (PR#10459) bug: pplayer_can_ally assert fail 		Home

[Freeciv-Dev] Re: (PR#10459) bug: pplayer_can_ally assert fail

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: bagpipe@xxxxxxxxx, bh@xxxxxxxxxxxxxxxxxxx, jorneg@xxxxxxxxxxx, marko.lindqvist@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#10459) bug: pplayer_can_ally assert fail
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 18 Oct 2004 11:16:05 -0700
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=10459 >

Per I. Mathisen wrote:

> Maybe we should just insert assert(pplayer->is_alive &&
> pplayer2->is_alive) in these functions, and catch all erronous callers?

Fine with me.  But not in the stable branch.  But maybe for the stable 
branch the best fix is just to remove the check from sanitycheck.c.

jason
[Prev in Thread] Current Thread [Next in Thread]