Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2004:
[Freeciv-Dev] Re: (PR#10459) bug: pplayer_can_ally assert fail 		Home

[Freeciv-Dev] Re: (PR#10459) bug: pplayer_can_ally assert fail

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: bagpipe@xxxxxxxxx, bh@xxxxxxxxxxxxxxxxxxx, marko.lindqvist@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#10459) bug: pplayer_can_ally assert fail
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Mon, 18 Oct 2004 09:28:01 -0700
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=10459 >

On Mon, 18 Oct 2004, Jason Short wrote:
> This seems wrong.If !pplayer->is_alive then player_can_ally should be
> false.Then sanity checking should just skip dead players.

That depends. If pplayer_can_ally() should accurately reflect who can be
allied, then it must be the way suggested in my patch. Since players who
are dead do not count towards the love-love-hate limitations. However, if
pplayer_can_ally() is just who can make new alliances, then your
suggestion is better.

  - Per
[Prev in Thread] Current Thread [Next in Thread]