[Freeciv-Dev] Re: (PR#10459) bug: pplayer_can_ally assert fail

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10459 >

On Mon, 18 Oct 2004, Jason Short wrote:
> Hmm. Perhaps this is complicated.  What kinds of situations would we
> actually be checking the diplomatic states of dead players, and care
> what result we got?
>
> What about this patch?It causes pplayers_allied, pplayers_at_war,
> pplayers_at_peace to all return false for dead players.

Oh my. There are assumptions about the return values of these functions
all over the codebase.

Maybe we should just insert assert(pplayer->is_alive &&
pplayer2->is_alive) in these functions, and catch all erronous callers?

  - Per