Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] Re: (PR#2521) effects patch

[Freeciv-Dev] Re: (PR#2521) effects patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: kaufman@xxxxxxxxxxxxxxxxxxxxxx, vasc@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2521) effects patch
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 27 Aug 2004 13:28:10 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: >

Vasco Alexandre da Silva Costa wrote:
> <URL: >
> On Wed, 25 Aug 2004, Jason Short wrote:
>><URL: >
>>What's the difference between an eff, an eft, and an effect?  Can't we
>>just always call it an effect?
> eff is a struct effect, eft is an enum effect_type.

IMO that's bad.  Aside from that they look almost identical eft is also 
a suitable shortening of effect.  Can we just call them effect and 

I'm not concerned with local variables but with global or file-wide 
types or fields.  I was rather confused by the EFF types in packets.def. 
  There is nothing about the REQ type that would make the casual reader 
think it has anything to with effects.


[Prev in Thread] Current Thread [Next in Thread]