[Freeciv-Dev] Re: (PR#9371) server crash cvs-20040712

["Jason Dorje Short" <jdorje@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9371 >

Guest wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9371 >
> 
> after i analyzed the situation further i guess my savefile may be corrupt?

RT sometimes corrupts binary files.  You can try sending it again 
uncompressed (or compressed again, since it usually works).

I used the first savefile you attached, which wasn't corrupted.  They 
both had the same name so I figured they were identical?   But maybe 
not.  Can you reproduce the problem with the first savefile?

> when i work around the nullpointer i see some strange changes to my
> game... instead of heaving hight tech units defending my cities i only
> have horses...
> 
> this is the 2nd time such a thing happens... i save a game, update
> freeciv zu cvs and then when i reload unit-mapping is changed...
> 
> and the update isnt over long time period... the difference between
> saving and cvsupping/loading is about 10 to 20 days or so...
> 
> so maybe this bug is related to the cvs update and loading an old game
> now incompatible... ?!

It's a long story, but the short version is that the savegames from ~1 
month ago and ~2 days ago are incompatable with those from earlier or 
later (but the earlier and later savegames are compatable with each 
other).  You can use the attached patch to work around the 
incompatability to load the old savegame with the new server.

However I doubt this relates to the bug you found.

jason

? diff
? test.diff
Index: server/savegame.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/savegame.c,v
retrieving revision 1.166
diff -u -r1.166 savegame.c
--- server/savegame.c   14 Jul 2004 22:50:24 -0000      1.166
+++ server/savegame.c   15 Jul 2004 15:39:59 -0000
@@ -584,7 +584,7 @@
 
 /* old (~1.14.1) unit order in default/civ2/history ruleset */
 static const char* old_default_unit_types[] = {
-  "Settlers",  "Engineers",    "Warriors",     "Phalanx",
+  "Settlers",  "Workers",      "Engineers",    "Warriors",     "Phalanx",
   "Archers",   "Legion",       "Pikemen",      "Musketeers",
   "Fanatics",  "Partisan",     "Alpine Troops","Riflemen",
   "Marines",   "Paratroopers", "Mech. Inf.",   "Horsemen",