[Freeciv-Dev] (PR#8720) Dynamtext

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8720 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Thu May 13 08:32:02 2004]:
> 
> On Wed, May 12, 2004 at 12:37:04PM -0700, Mike Kaufman wrote:
> > 
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=8720 >
> > 
> > On Wed, May 12, 2004 at 11:01:05AM -0700, Raimar Falke wrote:
> > > 
> > I'm not not all that hot about this patch. is it really necessary,
and now
> > requiring these macros to be used is ugly and annoying.
> 
> I agree that the macro definitions are ugly. But for the user of
> dynamtext they are easy to use. And especially easier to use and
> understand than the old mix of strcat, sprintf, cat_sprintf and so on.

OK but I don't like the implementation.

- It shouldn't go in shared.h just because there's nowhere better to put it.

- It should be an extension to astring (astring_add()) rather than its
own implementation.

- DYNAMTEXT_INIT is absolutely too ugly to be global.  Not only is it
unclear what it does but you can only have one per function.

jason