[Freeciv-Dev] Re: (PR#8720) Dynamtext

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8720 >

On Fri, May 21, 2004 at 11:19:10PM -0700, Jason Short wrote:
> OK but I don't like the implementation.
> 
> - It shouldn't go in shared.h just because there's nowhere better to put it.

What place you suggest?

> - It should be an extension to astring (astring_add()) rather than
> its own implementation.

You mean:
  void astring_add(struct astring *astr, const char *format, ...);
? I think I could like this.

> - DYNAMTEXT_INIT is absolutely too ugly to be global.  Not only is
> it unclear what it does but you can only have one per function.

So you want to split this into two? One for the declaration of astring
and for the setting it to ""? This is IMHO bad since it just screams
for forgetting the second one.

The issue of why and how it should be used can be fixed with some
docu.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  A supercomputer is a computer running an endless loop in just a second