[Freeciv-Dev] Re: (PR#8547) GCC poisoning v2

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8547 >

On Tue, Apr 20, 2004 at 11:18:17AM -0700, Per I. Mathisen wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8547 >
> 
> On Tue, 20 Apr 2004, Raimar Falke wrote:
> > Other question (which I also asked the last time): what are the
> > results? Do we have such bad function usage? Why do we have to add the
> > test framework into the normal code? Just add the results is fine.
> 
> I found about 4-7 erronous cases each time, I think. So it is not very
> common that these mistakes are made, but when they are, this is just about
> the only way that they are found ;)
> 
> Yes, we don't really have to have this activated all the time. If we just
> put in all the necessary changes (moving stuff around, headers), then the
> gcc poisoning _can_ be there but not used until we want to. However, if
> there are no good reasons against, I think adding gcc poisoning all the
> time might be just as good - it makes patch authors learn. Maybe commit
> with poisoning default on, then turn it off if people get problems?

Of course you can also run it 3-4 times a year and create a patch for
these 4-7 cases. I would prefer this.

What are the problems caused by not using the freeciv specific
functions?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "> WHY?! Isn't it better to put $(shell cat cscope.files) on the list of
  I only have a yellow belt in makefile kungfu.  These fancy gnu make things
  are relatively new to some of us..."
    -- Mark Frazer to Vassilii Khachaturov in linux-kernel