[Freeciv-Dev] Re: (PR#8547) GCC poisoning v2

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8547 >

On Tue, Apr 20, 2004 at 10:47:54AM -0700, Per I. Mathisen wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8547 >
> 
> On Tue, 20 Apr 2004, Raimar Falke wrote:
> > > What is bad: Moves stuff around without a clear idea of why some stuff
> > > should be here and some there (shared.h vs support.h).
> >
> > What is the reason for the bool change and the various unistd.h?
> 
> support.c has the forbidden functions, and must have them. So it cannot
> link in shared.h, yet it needs bool and the format macro - hence moving
> them over. shared.c can link in support.h without problems.
> 
> The various new includes: We have to be careful that we don't include
> system headers _after_ shared.h, or else the gcc poisoning will choke on
> these functions in the system headers. This becomes a problem because some
> freeciv header files include system headers (headers including headers is
> generally a terribly bad idea, but there you go), so we need to preempt
> these system headers included in freeciv headers by including them
> in the .c file first. The include guard ensures that we don't include them
> twice.
> 
> So where freeciv.c is
> 
>       #include "shared.h"
>       #include "freeciv.h"
> 
> and where freeciv.h contains
> 
>       #include <system.h>
> 
> they will fail, since the system header comes last. Whereas where
> freeciv.c is
> 
>       #include <system.h>
>       #include "shared.h"
>       #include "freeciv.h"
> 
> it will work fine, since by including the system header first in the .c
> file, the include guard ensures it is not included later.

Ok.

Other question (which I also asked the last time): what are the
results? Do we have such bad function usage? Why do we have to add the
test framework into the normal code? Just add the results is fine.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 A life? Cool! Where can I download one?