[Freeciv-Dev] Re: (PR#7446) center_on_something fails

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7446 >

Raimar Falke wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7446 >
> 
> On Mon, Apr 12, 2004 at 04:29:28PM -0700, Jason Short wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=7446 >
>>
>>Raimar Falke wrote:
>>
>>
>>>init_mapcanvas_and_overview should stay. Please research what is the
>>>real cause of this problem. No band-aids.
>>
>>Um, init_mapcanvas_and_overview is the cause of the problem.
>>
>>Before your patch that created init_mapcanvas_and_overview, the gtk2 
>>client had code like:
>>
>>   gtk_widget_show(toplevel);
>>   overview.store = NULL;
>>
>>now it is
>>
>>   gtk_widget_show(toplevel);
>>   init_mapcanvas_and_overview();
>>
>>in other words, the mapview was never "initted" before.  Now, however, 
>>it is configured when the toplevel window is shown (line 1) and later 
>>"initted" (e.g. overwritten) in line 2.
> 
> 
> So it should work if we switch the lines?

I don't think so.  Until the toplevel window is created we don't have a 
palette to create the canvas with.

jason