[Freeciv-Dev] Re: (PR#7446) center_on_something fails

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7446 >

On Mon, Apr 12, 2004 at 03:08:38PM -0700, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7446 >
> 
> > [jdorje - Fri Feb 20 01:47:34 2004]:
> > 
> > When you first start a game, the focus unit is put in the top-left of 
> > the mapview (not the center as it should be).
> 
> I can't reproduce this except in the gtk2 client.
> 
> I think the problem is that init_mapcanvas_and_overview is being called
> too much.  I think the mapview is being setup before the call to
> init_mapcanvas_and_overview.
> 
> But I can't compile the gtk2 client to test it.
> 
> The solution is simple.  Just remove init_mapcanvas_and_overview.  It
> doesn't do anything useful.  All it does is set some global (e.g.,
> already 0) values to 0, and create a stub mapview canvas (but this
> mapview canvas should never be used without being properly set up; that
> would be an error).
> 
> Alternately, just don't call it from the gtk2 client.

init_mapcanvas_and_overview should stay. Please research what is the
real cause of this problem. No band-aids.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  (On the statement print "42 monkeys"+"1 snake"): BTW, both perl and Python
  get this wrong. Perl gives 43 and Python gives "42 monkeys1 snake", when 
  the answer is clearly "41 monkeys and 1 fat snake".  
    -- Jim Fulton, 10 Aug 1999