Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2004:
[Freeciv-Dev] Re: (PR#8457) No assertion in post_receive_packet_player_a 		Home

[Freeciv-Dev] Re: (PR#8457) No assertion in post_receive_packet_player_a

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: matusik_s@xxxxx
Subject: [Freeciv-Dev] Re: (PR#8457) No assertion in post_receive_packet_player_attribute_chunk() !!!
From: "imbaczek@xxxxxxxxxxxxxx" <imbaczek@xxxxxxxxxxxxxx>
Date: Tue, 6 Apr 2004 11:56:35 -0700
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=8457 >

On 2004-04-06 you wrote:

> The pre-delta code checked partly for incorrect array sizes given. The
> delta code didn't do this at all. The attached patch fixed this. I'm
> not sure about the way to react if such a case is found. Feel free to
> change.

IMO bad/evil packets should be dropped, optionally with a log message.
Killing the servers will lead to DoS attacks.

-- 
{ Marek Baczyński :: UIN 57114871 :: GG 161671 :: JID imbaczek@xxxxxxxxxxxxx  }
{ http://www.vlo.ids.gda.pl/ | imbaczek at poczta fm | http://www.promode.org }
.. .. .. .. ... ... ...... evolve or face extinction ...... ... ... .. .. .. ..
[Prev in Thread] Current Thread [Next in Thread]