[Freeciv-Dev] Re: (PR#7637) Problem with line_width=2 [take 4]

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7637 >

On Sun, Mar 07, 2004 at 09:40:12AM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7637 >
> 
> Raimar Falke wrote:
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=7637 >
> > 
> > On Sat, Mar 06, 2004 at 12:59:54PM -0800, Jason Short wrote:
> > 
> >><URL: http://rt.freeciv.org/Ticket/Display.html?id=7637 >
> >>
> >>>[i-freeciv-lists@xxxxxxxxxxxxx - Sat Mar 06 20:55:34 2004]:
> >>>
> >>>
> >>>The comment of gui_put_line is plain wrong:
> >>>
> >>>  Draw a 1-pixel-width colored line onto the mapview or citydialog canvas.
> >>>
> >>>since the function also draws 2-pixel-width lines
> >>>
> >>>Additionally there is no clear semantic where the extra pixel of the 2
> >>>pixel width line should be placed. For odd line widths it is clear but
> >>>for even it isn't. Either this gets defined OR (what I would prefer)
> >>>the border code deals with it and calls gui_put_line two times.
> >>
> >>Very ugly.  I don't think it's possible to define it, since this depends
> >>on the library code.
> > 
> > Exactly. So the reason was to do multiple calls.
> 
> I think we should define it, and leave it up to the GUI implementation 
> to conform.  If it doesn't conform it's probably not too bad.
> 
> Also, I take back that it's impossible to conform.  If the GUI author 
> knows how his library works he can implement the standard by translating 
> the origin by a pixel or so.

How do you define it? Something like "The second pixel is always to
the right or bottom of the primary one?"

I think it is clearly easier to do multiple calls.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Programming today is a race between software engineers striving to
  build bigger and better idiot-proof programs, and the Universe trying
  to produce bigger and better idiots. So far, the Universe is winning."
    -- Rich Cook