[Freeciv-Dev] Re: (PR#7228) freeciv-client-gtk: City name problems (Unicode problem?)

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7228 >

On Mon, 12 Jan 2004, Vasco Alexandre da Silva Costa wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7228 >
>
> On Mon, 12 Jan 2004, Raimar Falke wrote:
>
> >
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=7228 >
> >
> > On Sat, Jan 10, 2004 at 05:06:28AM -0800, Jordi Mallach wrote:
> > > It's refusing to allow Århus as a city name, despite its being a name
> > > suggested by the game.  When I try to build the city, I get ``Jeu : on
> > > ne va pas construire une ville avec un nom aussi stupide.'' (Roughly,
> > > ``a city with such a stupid name cannot be built''!).  If I try to
> > > change it after construction, I get ``Århus n'est pas un nom valide''
> > > (``Århus is not a valid name'').  It's clearly not choking on the UTF8
> > > data completely, as it repeated the name back in the error message.
> > > Also, oddly, it was fine with ``København''!
> > >
> > > A little testing shows that it will accept ``Ã¥rhus,'' but it refuses to
> > > accept names where the first character is a capitalized non-ASCII char.
> > >
> > > I simply spelled the name Aarhus, but now it's going to get stuck on
> > > Århus and keep suggesting it to me -- not being Danish I suspect I'm
> > > going to run out of good Danish names in a hurry... ;)
> > >
> > > (FWIW, I had problems with being unable to use non-ASCII characters in
> > > king names, too -- ``Æþelred,'' for example, was rejected.)
> >
> > > Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8
> >
> > The relavant functions are: common/shared.c:is_sane_name() and
> > common/shared.c:is_iso_latin1(). Basically is_iso_latin1 tests for the
> > unused range 127-161 (~...¡). I suspect that this function is called
> > with utf-8 data. The server doesn't use utf-8. But GTK2 does.
>
> You mean it didn't use to use UTF-8. IIRC the server uses UTF-8 with the
> recent changes made in 1.14.1 to fix the UTF-8 locale bugs in the server.
>
> Jason should be able to inform you better about civserver changes.
>
> Yes, there is one occurrence of is_sane_name in the GTK+ 2.0 client. The
> server uses it in 5 places.
>
> > Vasco?
>
> is_sane_name must be rewritten to be more charset agnostic. At least it
> must support UTF-8, probably KOI8-R and EUC-JP as well.

I forgot the alternate solution. Don't allow non-ASCII leader or city
names, don't include non-ASCII strings in the rulesets.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa