[Freeciv-Dev] Re: (PR#7228) freeciv-client-gtk: City name problems (Unicode problem?)

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7228 >

On Tue, Jan 13, 2004 at 09:09:17AM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7228 >
> 
> >
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=7228 >
> >
> > On Mon, Jan 12, 2004 at 12:58:16PM -0800, Vasco Alexandre da Silva Costa
> > wrote:
> >> > The relavant functions are: common/shared.c:is_sane_name() and
> >> > common/shared.c:is_iso_latin1(). Basically is_iso_latin1 tests for the
> >> > unused range 127-161 (~...¡). I suspect that this function is
> >> called
> >> > with utf-8 data. The server doesn't use utf-8. But GTK2 does.
> >>
> >> You mean it didn't use to use UTF-8. IIRC the server uses UTF-8 with the
> >> recent changes made in 1.14.1 to fix the UTF-8 locale bugs in the
> >> server.
> >
> > Uhhh. Are you sure. Did I really miss this?
> 
> No, the server doesn't necessarily use UTF-8.
> 
> The data is stored in the rulesets in latin1, as before.  On loading, it
> is converted into the local character set.

Where does this happens?

$ grep -Irn iconv_open .|fgrep .c
./client/gui-sdl/gui_iconv.c:104:  iconv_t cd = iconv_open(pTocode, pFromcode);
./client/gui-sdl/gui_iconv.c:193:  cd = iconv_open(pTocode, pFromcode);
./intl/loadmsgcat.c:300:          domain->conv = iconv_open (outcharset, 
charset);

> This may be latin1, utf-8, or any other character set.  The original
> data is one-character-per-byte but after conversion it may not be.

So why hasn't is_latin1_char been changed/removed when this change was
made?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  +#if defined(__alpha__) && defined(CONFIG_PCI)
  +       /*
  +        * The meaning of life, the universe, and everything. Plus
  +        * this makes the year come out right.
  +        */
  +       year -= 42;
  +#endif
    -- Patch for 1.3.2 (kernel/time.c) from Marcus Meissner