[Freeciv-Dev] Re: Old patches

[Josh Cogliati <jjc@xxxxxxxxxxxxxxxxxx>]

On Mon, Aug 25, 2003 at 12:17:06PM +0100, Gregory Berkolaiko wrote:
> On Sun, 24 Aug 2003, Josh Cogliati wrote:
> 
> > I am amazed at how many of these old patches seem to have been dropped 
> > without
> > comment.  

> One can either grab a patch when he sees it, but, unfortunately, this 
> doesn't guarantee that the patch will go in after the review, especially 
> if this patch add a feature or, god forbid, changes rules.
> 
> Thus a better system would be when maintainers ask people to review 
> patches they are ready to commit in principle.  
Why can't maintainers send out a general comment saying that they are 
ready to commit a patch in principle pending sufficient peer review?

> Review others as you would have them review you!

Just did.  Reviewed 2252, 2406 and 3446.  2406 and 3446 should go in right 
now in my humble opinion.
 
-- 
Josh Cogliati