[Freeciv-Dev] Re: Old patches

[Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxx>]

On Sun, 24 Aug 2003, Josh Cogliati wrote:

> I looked through the old patches in rt today.  The following were the oldest
> nine patches that are still either open or new.  #1803 should be switched
> to resolved/patch-applied since the ai cleanup is in cvs.
> The rest should probably be marked dead since the last real activity
> was generally at least 9 months ago.
>
> #1178 looks interesting, but since the first public reply occured *11 months*
> after the author submitted it, I am assuming the author dspeyer lost interest.
>
> I am amazed at how many of these old patches seem to have been dropped without
> comment.

It happens. Often either for lack of time, bitrot, implementation quirks,
or a set of these.

I have taken ticket #1178.

> Here is my list.
> #244  patch: client scripting enhancement
>  Dropped with no discussion found.  Status probably should be dead
> #902 [gtk] message window remains hidden when in background (+ minimal patch)
>   Dropped with no discussion found.  Not sure if this is still a problem in
>       gtk2
> #1014 [PATCH] flags_in_front
>   Dropped after discussion.  No reason given.  Not sure if still a problem.
> #1136 Resend of code-cleanup patch of city dialog (happiness.c)
>   Dropped since it would soon be obsoleted by gen_impr (Note that this
>    was submitted in Dec 2001).
> #1151 find_representative_map_pos
>   Reason given for no inclusion.  No response from submitter.
>       Status should be dead.
> #1178 Active Units Dialog
>   No response given for 11 months.  Response thought patch was interesting
>       idea.  If someone can revive this patch, it might be interesting.
> #1351 [PATCH] Fixing Warriors
>   Discussed and no firm descision reached so left unchanged.  This should
>       probably be dead.
> #1494 [PATCH] an "autogame" server variable to control the autogame feature
>   No discussion and not applied.  This should probably be dead, unless someone
>       wants to revive this feature.
> #1803 unit move handling cleanup
>   Initial approval in discussion.  No discussion after last version of patch
>       posted.  RT does not list this as patched, but appears to have been
>       applied.  If this was applied, should be switched to
>       Resolved/patch-applied.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa