[Freeciv-Dev] Re: Old patches

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Sun, 24 Aug 2003, Josh Cogliati wrote:
> I looked through the old patches in rt today. The following were the oldest
> nine patches that are still either open or new. #1803 should be switched
> to resolved/patch-applied since the ai cleanup is in cvs.
> The rest should probably be marked dead since the last real activity
> was generally at least 9 months ago.

No, "dead" is only used for spam and virus mails. All tickets that have
been handled and no longer require attention should be marked "resolved".

> I am amazed at how many of these old patches seem to have been dropped without
> comment.

Often the patches were submitted to RT after a discussion, or the
discussion was not archived for some reason.

> Here is my list.
> #244 patch: client scripting enhancement
>  Dropped with no discussion found.Status probably should be dead

Should probably be marked resolved.

> #1351 [PATCH] Fixing Warriors
> Discussed and no firm descision reached so left unchanged.

This should go to the design board.

> #1803 unit move handling cleanup
> Initial approval in discussion.  No discussion after last version of patch
>       posted. RT does not list this as patched, but appears to have been
>       applied. If this was applied, should be switched to
>       Resolved/patch-applied.

This one was partially committed, the AI portions of the patch have been
in cvs for a while. Just recently I made a new attempt to ressurect the
remaining code, but it is a bit of a challenge to get the architecture
right. Don't touch.

  - Per