[Freeciv-Dev] (PR#3745) Diplomacy patch (alpha version)

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

I really, really dislike those MAKE_BUTTON macros. IMO they make the
code harder to read for little gain. There must be a cleaner way of
doing this.

The diplomacy dialog still uses the same code as in the GTK+ 1.2 client.
If that dialog works in GTK+ 2.0 it should work in 1.2. :-)

I need to rewrite that dialog eventually. That should make that code
cleaner. This may be done after your patch.

Note: Don't bother using macros for performance instead of functions for
things like this. The GTK+ core is ridden with function calls as is
already. GtkTreeView in GTK+ 2.0 for e.g. is a nightmare.