[Freeciv-Dev] Re: Performace of path-finding (PR#2370)

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Sun, Mar 16, 2003 at 10:23:36PM +0000, Gregory Berkolaiko wrote:
> Raimar,
> 
> 
> Quoting Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>:
> 
> > On Fri, Mar 14, 2003 at 12:48:21PM +0000, Gregory Berkolaiko wrote:
> > > > Same here. These numbers are too good. We have to compare the MC of
> > > > the tiles. And check the number of iterations.
> > 
> > A direct comparsions shows that maxcost needs to be increased. Also 
> 
> I m really not sure which maxcost you are talking about.  I see
> maxcost=250 in your patch but it's not used anywhere.

        if (WARMAP_COST(x1, y1) > move_cost && move_cost < maxcost) {
          WARMAP_COST(x1, y1) = move_cost;
          add_to_mapqueue(move_cost, x1, y1);
        }


> >       if (is_ground_unit(punit)) {
> >         really_generate_warmap(pcity, punit, LAND_MOVING);
> >       }
> > needs to be changed to
> >       if (is_ground_unit(punit)) {
> >         really_generate_warmap(NULL, punit, LAND_MOVING);
> >       }
> 
> That doesn't matter as really_generate_warmap ignores pcity if punit
> is non-NULL.

  if (pcity) {
    orig_x = pcity->x;
    orig_y = pcity->y;
    pplayer = city_owner(pcity);
  } else {
    orig_x = punit->x;
    orig_y = punit->y;
    pplayer = unit_owner(punit);
  }

> > Sometimes the results are of by one move point. Explorers show
> > different results by a factor of 3.
> 
> First I will check.  Second is well known (the warmap is wrong for IGTER).

Ok.

> What are the speed numbers?

I didn't measure.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "This is Linux Country. On a quiet night, you can hear Windows reboot."