[Freeciv-Dev] Re: (PR#2521) general effects framework

["Ben Webb via RT" <rt@xxxxxxxxxxxxxx>]

On Mon, Jan 13, 2003 at 02:30:54PM -0800, Mike Kaufman via RT wrote:
> On Mon, Jan 13, 2003 at 04:17:36AM -0800, Ben Webb via RT wrote:
> Content-Description: effects-cleanup.patch
> > --- README.effects  2003-01-13 12:06:21.000000000 +0000
> > +++ README.effects.impr-gen 2003-01-13 12:06:11.000000000 +0000
> > @@ -39,6 +39,10 @@
> >  "Food_Bonus"       - food production is increased by AMOUNT percent
> >               (all Food_Bonus' are summed before being applied)
> >  
> > +"Food_Pct" - multiplies total food production by AMOUNT percent
> > +             (applied after Food_Bonus; multiple effects are
> > +             multiplicative)
> 
> whoa, are we _sure_ we want these to be multiplicative??

Sure, why not? If you apply two Food_Pct effects with amount=300, you
should end up with 9 times the orginal food production. Adding them to
get 6 times the production would make no sense (that's what Food_Bonus
is for). For a start, an amount of 0 wouldn't kill any production (see
the pollution percentage bonuses) if you added it to other bonuses.

        Ben
-- 
ben@xxxxxxxxxxxxxxxxxxxxxx           http://bellatrix.pcl.ox.ac.uk/~ben/
"Mars is essentially in the same orbit... Mars is somewhat the same 
distance from the Sun, which is very important. We have seen pictures 
where there are canals, we believe, and water. If there is water, that 
means there is oxygen. If oxygen, that means we can breathe."
        - Vice President Dan Quayle, 8/11/89