[Freeciv-Dev] Re: (PR#2466) Display of city revolt state deferred

["ChrisK@xxxxxxxx via RT" <rt@xxxxxxxxxxxxxx>]

On Tue, Dec 03, 2002 at 10:39:31AM -0800, Raimar Falke via RT wrote:
> On Tue, Dec 03, 2002 at 09:23:00AM -0800, ChrisK@xxxxxxxx via RT wrote:
> > On Tue, Dec 03, 2002 at 04:41:27AM -0800, Reinier Post via RT wrote:
> > > On Mon, Dec 02, 2002 at 10:35:59AM -0800, ChrisK@xxxxxxxx via RT wrote:
> > > 
> > > > This is not quite true. The display for other players is updated at
> > > > beginning of the turn, so they get to know anyway. And I don't see
> > > > how they could take advantage of that information. But ok, they
> > > > don't _need_ to know (before next turn).
> > > 
> > > My diplomats post nearby enemy cities, waiting for them to be in turmoil
> > > so they are cheaper to bribe.
> > 
> > Question: the turmoil state as a factor for bribe cost is determined
> > (1) at turn change or (2) real time? I guess (1). That means: if a city
> 
> It is 2. server/unithand.c:handle_incite_inq for the query and it is
> also calculated a second time in server/diplomats.c:diplomat_incite.

I want to add, the turmoil display is inconsistent. It shows the lightning
symbol, when a city gets in turmoil, but it does not remove the symbol,
when the turmoil ends. That means, if a turmoil is created _and_ resolved
in the very same turn, the game reports no turmoil to the player, but
turmoil is shown to other players (by that symbol).

There is a function that makes revolution if turmoil exists for several
subsequent turns, but this function counts only "real" turmoils (that
extend over turn change) AFAIK. So the turmoil is displayed, but not
counted.

Either the lightning symbol shows only "real" turmoil (that exists
at start of turn), or it displays the "transitory" turmoil. The latter
requires, that the symbol is deleted when turmoil ends. This is currently
not the case. It is only deleted at start of new turn.

On the bribery, I think, only "real" turmoil should be respected. It is
easy to cheat now: put some ships in front of the city --> the city gets
in turmoil (at least if CMA is not used) --> bribe the city. Theoretically
it is also possible to use the trick _with_ CMA, if you bribe the city
before CMA adapts the setting.

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.